Serial: removed the validateBaudrate function from nuttx and posix platforms and just send out a warning it baudrate is non-standard (#22969)

- Fix some Qurt platform build issues uncovered when changing the posix version of SerialImpl
This commit is contained in:
Eric Katzfey
2024-04-04 12:07:46 -04:00
committed by GitHub
parent 047e900c2a
commit 0a867b5d1d
11 changed files with 295 additions and 56 deletions
+3 -24
View File
@@ -68,28 +68,11 @@ SerialImpl::~SerialImpl()
}
}
bool SerialImpl::validateBaudrate(uint32_t baudrate)
{
return ((baudrate == 9600) ||
(baudrate == 19200) ||
(baudrate == 38400) ||
(baudrate == 57600) ||
(baudrate == 115200) ||
(baudrate == 230400) ||
(baudrate == 460800) ||
(baudrate == 921600));
}
bool SerialImpl::configure()
{
/* process baud rate */
int speed;
if (! validateBaudrate(_baudrate)) {
PX4_ERR("ERR: unknown baudrate: %lu", _baudrate);
return false;
}
switch (_baudrate) {
case 9600: speed = B9600; break;
@@ -116,8 +99,9 @@ bool SerialImpl::configure()
case 921600: speed = B921600; break;
default:
PX4_ERR("ERR: unknown baudrate: %lu", _baudrate);
return false;
speed = _baudrate;
PX4_WARN("Using non-standard baudrate: %lu", _baudrate);
break;
}
struct termios uart_config;
@@ -374,11 +358,6 @@ uint32_t SerialImpl::getBaudrate() const
bool SerialImpl::setBaudrate(uint32_t baudrate)
{
if (! validateBaudrate(baudrate)) {
PX4_ERR("ERR: invalid baudrate: %lu", baudrate);
return false;
}
// check if already configured
if ((baudrate == _baudrate) && _open) {
return true;
@@ -109,7 +109,6 @@ private:
StopBits _stopbits{StopBits::One};
FlowControl _flowcontrol{FlowControl::Disabled};
bool validateBaudrate(uint32_t baudrate);
bool configure();
bool _single_wire_mode{false};