From 0749b04c9f29da8dc31a1217098f2199981a73ee Mon Sep 17 00:00:00 2001 From: Pavel Kirienko Date: Thu, 26 May 2016 21:00:10 +0300 Subject: [PATCH] Fixed stack overflow in UAVCAN process (#4643) * Increased uavcan stack size; the old value of 1800 was insufficient * Removed a misleading warning message from uavcan servers initialization --- src/modules/uavcan/uavcan_main.hpp | 2 +- src/modules/uavcan/uavcan_servers.cpp | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/modules/uavcan/uavcan_main.hpp b/src/modules/uavcan/uavcan_main.hpp index 5c7d764602..46195a3203 100644 --- a/src/modules/uavcan/uavcan_main.hpp +++ b/src/modules/uavcan/uavcan_main.hpp @@ -103,7 +103,7 @@ class UavcanNode : public device::CDev */ static constexpr unsigned RxQueueLenPerIface = FramePerMSecond * PollTimeoutMs; // At - static constexpr unsigned StackSize = 1800; + static constexpr unsigned StackSize = 2400; public: typedef uavcan_stm32::CanInitHelper CanInitHelper; diff --git a/src/modules/uavcan/uavcan_servers.cpp b/src/modules/uavcan/uavcan_servers.cpp index 5ed3e83ee6..7e372a1d91 100644 --- a/src/modules/uavcan/uavcan_servers.cpp +++ b/src/modules/uavcan/uavcan_servers.cpp @@ -923,7 +923,6 @@ void UavcanServers::unpackFwFromROMFS(const char* sd_path, const char* romfs_pat DIR* const romfs_dir = opendir(romfs_path); if (!romfs_dir) { - warnx("base: couldn't open %s", romfs_path); return; }