diff --git a/src/modules/control_allocator/VehicleActuatorEffectiveness/ActuatorEffectivenessHelicopter.cpp b/src/modules/control_allocator/VehicleActuatorEffectiveness/ActuatorEffectivenessHelicopter.cpp index 3be0808d2c..883b22c184 100644 --- a/src/modules/control_allocator/VehicleActuatorEffectiveness/ActuatorEffectivenessHelicopter.cpp +++ b/src/modules/control_allocator/VehicleActuatorEffectiveness/ActuatorEffectivenessHelicopter.cpp @@ -106,17 +106,16 @@ void ActuatorEffectivenessHelicopter::updateParams() param_get(_param_handles.max_servo_throw, &max_servo_throw_deg); if (max_servo_throw_deg > 0.f) { - //linearization feature enabled + // linearization feature enabled + _geometry.linearize_servos = 1; const float max_servo_throw = math::radians(max_servo_throw_deg); _geometry.max_servo_height = sinf(max_servo_throw); _geometry.inverse_max_servo_throw = 1.f / max_servo_throw; - _geometry.linearize_servos = 1; - } else { + } else { // handle any undefined behaviour if disabled - _geometry.max_servo_height = 0.f; - _geometry.inverse_max_servo_throw = 0.f; _geometry.linearize_servos = 0; + _geometry.max_servo_height = _geometry.inverse_max_servo_throw = 0.f; } } @@ -204,17 +203,17 @@ void ActuatorEffectivenessHelicopter::updateSetpoint(const matrix::Vector